Install CRDs in operator upgrade tests #63
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsierant
force-pushed
the
lsierant/upgrade-tests-install-crds
branch
from
bdeaf5f to
6829f1e
Compare
lsierant
force-pushed
the
lsierant/upgrade-tests-install-crds
branch
from
b9ba56d to
25ba545
Compare
|
@lsierant could you please rebase it this PR? I think we need this to fix some jobs on master. |
3 tasks
|
Closing this to avoid confusion as it was rebased in #127 |
mircea-cosbuc
added a commit
that referenced
this pull request
May 16, 2025
# Summary #63 rebased on `master` branch. ## Proof of Work <!-- Enter your proof that it works here.--> ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question --------- Co-authored-by: Łukasz Sierant <lukasz.sierant@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Manually installing CRDs is required when the operator is installed because helm is not applying them if the CRDs already exist.
Apart from adding
kubectl apply helm_chart/crdsinstallation step, this PR adds always printing subprocess output even in successful runs.Proof of Work
Green upgrade tests in general, but here this patch won't make much of a difference as there are no new CRDs.
But in another pipeline, when MongoDBSearch CRDs were added, the upgrade tests are failing - the operator is crashing due to lack of search CRDs.
After using this commit upgrade tests are green: link TBD
Checklist
Reminder (Please remove this when merging)